Skip to content

Runtime array bounds check #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorchard merged 1 commit into from
Dec 18, 2025
Merged

Runtime array bounds check #255

dorchard merged 1 commit into from
Dec 18, 2025

Conversation

@jacobpake
Copy link
Member

@jacobpake jacobpake commented Apr 5, 2025 •
edited
Loading

Previously we were allowing read/write to index = length e.g.

-- 100
main : Float
main =
    unpack<id, arr> = newFloatArray 0 in
    let arr' = writeFloatArray arr 0 100.0 in
    let (x, arr'') = readFloatArray arr' 0 in
    let () = deleteFloatArray arr'' in
    x

For immutable arrays this was caught by the Haskell IOArray after our checks.

This PR changes the bound check to fail on index >= length rather than index > length.

BinderDavid
BinderDavid approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@BinderDavid BinderDavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dorchard dorchard merged commit f1da16f into main Dec 18, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BinderDavid BinderDavid BinderDavid approved these changes

@starsandspirals starsandspirals Awaiting requested review from starsandspirals

Assignees

No one assigned

Labels

hackathon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jacobpake @BinderDavid @dorchard